Update to subsyncarr #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update docker-compose.yaml * Update README.md * Update README.md * Update docker-compose.yaml * Delete .env.example
…c#13) Co-authored-by: John Corser <xss@amazon.com>
Co-authored-by: John Corser <xss@amazon.com>
Co-authored-by: John Corser <xss@amazon.com>
Owner
|
Hey thanks for this contribution! Unfortunately there's a lot of merge conflicts that makes the diff hard to review. Would you mind running then pushing the resulting merge commit to your branch? That would really help! One minor nit from my 10 seconds I spent looking so far, I think .DS_STORE should be added to .gitignore and not included in the diff |
add memory optimization settings for Node.js in Dockerfile
Fix race conditions in ProcessingCoordinator causing crashes
… to see names of films skipped, completed or failed
Author
|
Heya - i've made these changes and a couple of extra ones. Let me know what you think! Happy to keep them separate if you prefer but thought some of the updates were useful. Best wishes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was having loads of issues with my subtitles and came across your software which worked great!
I ran into a couple of issues while using it like the alignment getting stuck on some particular files that I didn't want to remove from the library.
I've created a small webUI and added a couple of these features to the app and it's been perfect. I've been using it about a week and it's doing exactly what I hoped.
I'm happy to keep my fork separate if it's super far from what you envisioned but thought i'd see if you wanted to merge as an update to the official software you've made. Happy to re-write the readme etc if needed.
Best,
Tom